Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1249) - Fix Spinner on Windows Hosts #514

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jordanbreen28
Copy link
Contributor

This PR fixes an incompatibility issue with windows hosts and tty spinner.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Fixes #144

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner July 26, 2023 12:46
This commit fixes an incompatibility issue with windows hosts and tty
spinner.
@jordanbreen28 jordanbreen28 force-pushed the CAT-1249-fix_spinner_on_windows_host branch from 6151a88 to 7672169 Compare July 26, 2023 12:52
Copy link
Contributor

@pmcmaw pmcmaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pmcmaw pmcmaw merged commit 325c3e6 into main Jul 27, 2023
2 checks passed
@pmcmaw pmcmaw deleted the CAT-1249-fix_spinner_on_windows_host branch July 27, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix spinners on non-ansi terminals (windows, CI)
2 participants