(FEAT) - Add ability to supply a custom matrix and override default provisioner #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
feat-override_default_provisioner
branch
from
11fd067
to
7d9c9ad
Compare
GSPatton
reviewed
Jul 6, 2023
Co-authored-by: Gavin Patton <[email protected]>
GSPatton
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to override the default provider for the litmus images from docker to the provision_service, by supplying the
--provision-serviceflag.It also adds the ability to supply a custom matrix (supplied as a file path), so the user can define their images, providers and labels used by matrix_from_metadata_v2. This can be done by passing the
--custom-matrix /path/to/matrix.jsonargument.Additional Context
This PR also removes the unnecessary
provision::prefix from the provisioner, to prevent this error being continuously thrown:Unsupported provisioner 'provision::docker', try abs/docker/docker_exp/provision_service/vagrant/vmpoolerRelated Issues (if any)
Closes #453
Checklist