Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add removed methods #249

Closed

Conversation

mhashizume
Copy link
Contributor

Two methods were mistakenly removed from both Beaker and beaker-puppet, breaking tests for modules.

puppet_agent_dev_package_info was removed in Beaker in voxpupuli/beaker@cdaedad under the mistaken assumption that it had already been moved over to beaker-puppet.

install_puppet_agent_dev_repo_on was removed in beaker-puppet in 22a38c8 because it relied on puppet_agent_dev_package_info, which was no longer available.

This commit restores those two methods (with some minor modifications for platforms that are no longer supported) and their associated tests.

Two methods were mistakenly removed from both Beaker and beaker-puppet,
breaking tests for modules.

puppet_agent_dev_package_info was removed in Beaker in
voxpupuli/beaker@cdaedad under the mistaken assumption that it had
already been moved over to beaker-puppet.

install_puppet_agent_dev_repo_on was removed in beaker-puppet in
22a38c8 because it relied on puppet_agent_dev_package_info, which was no
longer available.

This commit restores those two methods (with some minor modifications
for platforms that are no longer supported) and their associated tests.
@mhashizume mhashizume added the bug label Feb 29, 2024
@mhashizume
Copy link
Contributor Author

I think I misunderstood the test failures I was seeing and this isn't actually necessary. Closing out PR.

@mhashizume mhashizume closed this Mar 5, 2024
@mhashizume mhashizume deleted the readd-agent-dev-methods branch March 5, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant