Add release prep script #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| docker run -it --rm -e CHANGELOG_GITHUB_TOKEN -v $(pwd):/usr/local/src/your-app \ | |||
There was a problem hiding this comment.
your-app seems a little bit suspect here, is it supposed to be replaced with maybe beaker-puppet?
There was a problem hiding this comment.
I think that's okay--from a quick look at other repos that use this automation, it seems like that path is local to the container and more or less a temporary staging area for the changelog after it's been generated.
Tefoji ran a release prep action a few weeks ago: https://github.com/puppetlabs/tefoji/actions/runs/7732718060/job/21083254959
Which shows this in the logs:
Generated log placed in /usr/local/src/your-app/CHANGELOG.md
And created this PR: https://github.com/puppetlabs/tefoji/pull/107
mhashizume
force-pushed
the
release-prep-script
branch
from
45c0001
to
3f3a24c
Compare
This commit adds the release script prep necessary for calling the auto_release_prep workflow. This script is taken from https://github.com/puppetlabs/release-engineering-repo-standards
mhashizume
force-pushed
the
release-prep-script
branch
from
3f3a24c
to
788151e
Compare
joshcooper
approved these changes
Feb 14, 2024
|
Sorry meant to just approve and let Tony review, but I got carried away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the release script prep necessary for calling the auto_release_prep workflow.
This script is taken from https://github.com/puppetlabs/release-engineering-repo-standards