Move to Puppet release GitHub Actions #242
Conversation
|
Setting as a draft until I can get the appropriate secrets added to this repo. |
mhashizume
force-pushed
the
release-process
branch
from
4ab95ca
to
4bc0b5a
Compare
|
Thanks for the review @bastelfreak , could you take another look when you get the chance? Thanks! |
|
|
||
| jobs: | ||
| release: | ||
| runs-on: ubuntu-latest | ||
| if: github.repository_owner == 'voxpupuli' | ||
| if: github.repository == 'puppetlabs/beaker-puppet' |
There was a problem hiding this comment.
this is totally fine, but: For Vox Pupuli we switched from github.repository to github.repository_owner because it turned out people often copy and paste the action to new repos we have and forget to adjust it :D
| echo "Found version $version from lib/beaker-puppet/version.rb" | ||
|
|
||
| - name: Generate Changelog | ||
| uses: docker://githubchangeloggenerator/github-changelog-generator:1.16.2 |
There was a problem hiding this comment.
at vox pupuli we had random concurrency issues with versions below 1.16.4 where PRs and issues got the wrong author in the CHANGELOG.md.
There was a problem hiding this comment.
Yeah, we've ran into that issue with some of our modules too but that was when using the gem. I haven't had personal experience with the Docker image (I did not write this workflow), but I have not heard of any issues from other Puppet teams who've used this workflow.
This commit replaces the release process implemented by Vox Pupuli with Puppet's gem release GitHub Actions.
mhashizume
force-pushed
the
release-process
branch
from
4bc0b5a
to
fee8b61
Compare
This commit replaces the release process implemented by Vox Pupuli with Puppet's gem release GitHub Actions.