Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling and cleanup resources.go #456

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Fix spelling and cleanup resources.go #456

merged 5 commits into from
Sep 9, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Sep 9, 2024

Fixes #452

This fix is non-breaking. The old misspelled resource has been deprecated, and now points to the new (correctly spelled) resource.

@iwahbe iwahbe self-assigned this Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • index/kinesisLogSource.KinesisLogSource

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breaking changes bot does not seem to catch the rename. LGTM!

@iwahbe
Copy link
Member Author

iwahbe commented Sep 9, 2024

The breaking changes bot does not seem to catch the rename. LGTM!

I think the bot is correct. The problem is that the major-version field in .ci-mgmt.yaml is wrong. Fixed in fix the major version in .ci-mgmt.yaml.

@iwahbe iwahbe merged commit 462b8ca into master Sep 9, 2024
23 checks passed
@iwahbe iwahbe deleted the iwahbe/cleanup branch September 9, 2024 11:42
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v0.23.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misspelling of KinesisLogSource as KineisLogSource
3 participants