Do not create instance role when skipDefaultNodeGroup is enabled
#1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flostadler
added
the
needs-release/major
Does the PR have any schema changes?Looking good! No breaking changes found. |
flostadler
commented
Oct 3, 2024
sdk/python/pulumi_eks/_inputs.py
Outdated
| @@ -289,7 +289,7 @@ class ClusterNodeGroupOptionsArgsDict(TypedDict): | |||
|
|
|||
| Note: Given the inheritance of auto-generated CF tags and `cloudFormationTags`, you should either supply the tag in `autoScalingGroupTags` or `cloudFormationTags`, but not both. | |||
| """ | |||
| bootstrap_extra_args: NotRequired[str] | |||
| bootstrap_extra_args: NotRequired[pulumi.Input[str]] | |||
There was a problem hiding this comment.
Are we missing CI check guarantees that the worktree should be clean possibly?
There was a problem hiding this comment.
We're merging those into a feature branch that's only built when cutting an alpha release or when triggered manually. It's checking it as part of those workflows
t0yv0
reviewed
Oct 3, 2024
docs/eks-v3-migration.md
Outdated
|
|
||
| ### Cluster does not create extraneous instance IAM role if `skipDefaultNodeGroup` is set to `true` | ||
|
|
||
| Previously the Cluster component created a default instance IAM role even if `skipDefaultNodeGroup` was set to `true`. This role gets correctly omitted now if you're specifying `skipDefaultNodeGroup`. |
t0yv0
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling
skipDefaultNodeGroupwe should not be creating resources related to the default node group. This includes the default instance role.With this change the
Clustercomponent will no longer create this default role whenskipDefaultNodeGroupis enabled.One of the tests needs re-recording because we're introducing a breaking change (i.e. not creating the extraneous instance role), but in doing so we're aligning the provider with user expectations. Once this is merged in I'll release the next version and re-record.
Fixes #1176