Do not assume ExpectRefreshChanges: true for all tests #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
Found an interesting problem: #1568 |
|
Another set of failures are due to pulumi/pulumi-terraform-bridge#1595 |
|
LB example further cycles because of #1572 - I fixed the example but leaving the issue in case there are more problems of this sort in general, as there likely are. |
t0yv0
changed the title
iwahbe
approved these changes
Dec 28, 2023
|
Yeah that's filed in #1572. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change unexpected refresh change were ignored for all example-based integration tests via
ExpectRefreshChanges: true, so accidentally regressing on this would have gone unnoticed. After the PR such settings are only set on examples that currently need them and they are cross-linked with issues causing the problem.