-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate weekly pulumi/pulumi upgrade #1298
Conversation
This reverts commit fd16714.
4f319d6
to
593cfd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good idea.
@@ -0,0 +1,79 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having trouble understanding why this script isn't just
go get -u github.com/pulumi/pulumi/pkg/v3
go get -u github.com/pulumi/pulumi/sdk/v3
go mod tidy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looking at it again you're right. I was a bit over-careful with logging exactly what's happening in the update steps, but that's just making the script harder to grasp.
The versioning bit I wanted to have in order to include that in the commit and PR info. It also ensure we have consistent versions across the modules PR. e.g. when a new pu/pu version is released midway through the workflow run; even if it's rather unlikely to happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err on the side of merging, can fixup or edit as needed I think. Thank you! One day perhaps a common way to do this in ci-mgmt but it doesn't have to be now.
CC @danielrbradley who is working on unifying theses repos in ci-mgmt. |
Co-authored-by: Ian Wahbe <[email protected]>
This sets up a cron job to bump pulumi/pulumi versions every week. The cron job updates the dependencies, rebuilds the provider and then opens a PR. The PR is set to auto merge.
Closes #1264