Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate weekly pulumi/pulumi upgrade #1298

Merged
merged 20 commits into from
Jun 5, 2024
Merged

Conversation

flostadler
Copy link
Contributor

This sets up a cron job to bump pulumi/pulumi versions every week. The cron job updates the dependencies, rebuilds the provider and then opens a PR. The PR is set to auto merge.

Closes #1264

@flostadler flostadler self-assigned this Jun 4, 2024
@flostadler flostadler requested review from a team and t0yv0 June 4, 2024 14:24
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good idea.

.github/workflows/weekly-pulumi-update.yml Show resolved Hide resolved
@@ -0,0 +1,79 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble understanding why this script isn't just

go get -u github.com/pulumi/pulumi/pkg/v3
go get -u github.com/pulumi/pulumi/sdk/v3
go mod tidy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looking at it again you're right. I was a bit over-careful with logging exactly what's happening in the update steps, but that's just making the script harder to grasp.

The versioning bit I wanted to have in order to include that in the commit and PR info. It also ensure we have consistent versions across the modules PR. e.g. when a new pu/pu version is released midway through the workflow run; even if it's rather unlikely to happen

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err on the side of merging, can fixup or edit as needed I think. Thank you! One day perhaps a common way to do this in ci-mgmt but it doesn't have to be now.

@iwahbe
Copy link
Member

iwahbe commented Jun 4, 2024

Err on the side of merging, can fixup or edit as needed I think. Thank you! One day perhaps a common way to do this in ci-mgmt but it doesn't have to be now.

CC @danielrbradley who is working on unifying theses repos in ci-mgmt.

@flostadler flostadler merged commit 1e5fee9 into master Jun 5, 2024
10 checks passed
@flostadler flostadler deleted the automate-pulumi-upgrade branch June 5, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate keeping pulumi/pkg reference updated on a weekly cadence
3 participants