Respect schema version #1539
Merged
Respect schema version #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade pu/pu CLI to ensure we have the extra version argument available.
- Remove manual updating of the version number for python and nodejs now the version number is already set. - Fix dotnet so the version.txt has the provider version *not* the dotnet SDK version. - Remove unneeded shell wrapping in bin/pulumi-java-gen target which actually causes the download to happen while make is calculating the target rather than when it runs the target.
78 tasks
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1539 +/- ##
==========================================
- Coverage 25.12% 25.09% -0.03%
==========================================
Files 34 34
Lines 4542 4547 +5
==========================================
Hits 1141 1141
- Misses 3231 3236 +5
Partials 170 170 ☔ View full report in Codecov by Sentry. |
corymhall
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of pulumi/ci-mgmt#915
respectSchemaVersionfor python, go, nodejs and dotnet.