Embed version into the SDKs #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We already have "respectSchemaVersion" set in the schema, but we don't have a version set in the schema so it had no effect. - Set the version in the schema via the generate program - passed in as a new argument. - Move generation of the go.mod stubs into the generate step so `make generate` doesn't leave a dirty working tree. - Remove sed from nodejs build - just copy the package which now already has the version set. - Fix setting the `PACKAGE_VERSION` env var for the Java build - makefile variables are not env variables.
- Less generally used name and matches all other providers.
- Fix actionlint issues. - Use provider-version action for PRs.
- Allow for changes to the version number.
78 tasks
|
First test release run (not pushing any external assets): https://github.com/pulumi/pulumi-aws-apigateway/actions/runs/10079354997 Full prerelease test: |
- Prefer use of built-in feature over third party action. - Will appear in a single, cohesive job. Mirror all inputs Set same defaults so it doesn't skip the different steps
- Disable Java for pre-releases. - Set up AWS credentials for release verification. - Make the python release idempotent.
- Use the transformed version that's being released.
- Update from pulumi v3.107.0 to v3.126.0. - Delete pulumi-gen-aws-apigateway binary. - Re-generate all SDKs. - Update sdk/go.mod to use matching pulumi SDK version.
danielrbradley
force-pushed
the
embed-sdk-version
branch
from
73b025a
to
a2646cb
Compare
- Default region if not set to same as CI. - Set binary path via pulumi config rather than relying on $PATH discovery order. - Produce the provider binary as part of `make build_provider` rather than having to run `make install_provider`. Leave the latter as an alias.
- Fix version of pulumi/sdk to be the same everywhere. - Fix routes actually being inputty. Unclear why this wasn't the case before. - Tidy provider go.mod - Fix extra validation to use same region as the main test (not relying on the AWS_REGION to be set).
- It seems to have a delay before it's listed in the index and causes the test to fail. - Wait up to 15 minutes before continuing.
danielrbradley
commented
Jul 25, 2024
- Actually run python integration tests. - Remove broken relative reference. - Fix wrong python package name.
t0yv0
reviewed
Jul 25, 2024
t0yv0
reviewed
Jul 25, 2024
This can be reverted once pulumi/pulumi#16810 has been fixed.
danielrbradley
added a commit
that referenced
this pull request
Jul 26, 2024
This reverts commit b978236.
Merged
|
This PR has been shipped in release v2.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to pulumi/ci-mgmt#915
Update local build process
make generatedoesn't leave a dirty working tree.PACKAGE_VERSIONenv var for the Java build - makefile variables are not env variables.VERSIONtoPROVIDER_VERSIONto match other providers.Update CI
PROVIDER_VERSIONin all workflows.Additional work
pulumi package gen-sdkwherein we also bump up to the latest version of pulumi.