-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed SDK version #920
Embed SDK version #920
Conversation
- Run tfgen & build if we've changed anything to ensure SDKs are up to date.
@danielrbradley Can you pick a bridged provider and deploy this code all the way through a release? |
Rolling out to pulumi-azure as a test:
|
A couple of warts we might want to address that I spotted during the first test rollout:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of warts we might want to address that I spotted during the first test rollout:
- The SDK commit actually contains all the SDKs, not only the Go SDK. This is because we just point the Go SDK publish action as the module - which is
sdk/
- where the go.mod lives - which also includes all the other SDKs. This isn't a massive issue, but perhaps we could extend the action to allow globbing to select which files to include/exclude.- Linked to the above issue, we also include the
go.tar.gz
file as we currently always download the assets into the sdk folder rather than a temp directory ... which results in it getting included when we publish thesdk/...
go module.
I think it's worth addressing both before we deploy to all providers. I don't want to regress in download size, so we need to address the second point before deploying. For simplicity sake, I would like to address the first point as well, but it's not necessary.
but perhaps we could extend the action to allow globbing to select which files to include/exclude
Instead, can we just hard-code the list of paths we want to include? Right now, any pulumi provider should have all of their go code within sdk/{go.mod,go.sum,go}
. pulumi/publish-go-sdk-action@v1
can just know that.
Done - I make the action customisable with globs for the files to include, then customised the list of files for our use case within ci-mgmt as this might change in the future as we do things like move the go.mod one day or publish to a different repo. Rolling out a release for the xyz provider to test this last change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sensible
Related to #915 and https://github.com/pulumi/home/issues/3372