Allow skipping the Go SDK verification when invoking directly #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't test Go SDKs for pre-releases because we don't publish the Go SDKs for them. This is already implemented when invoked via a workflow_call, but the option wasn't available when using a workflow_dispatch (manual run).
danielrbradley
added a commit
to pulumi/pulumi-azure
that referenced
this pull request
Sep 13, 2024
- Set location explicitly in the programs instead of assuming program test will set it for us. - Disable python as it currently breaks for pre-releases (see pulumi/verify-provider-release#39) Manual test run: https://github.com/pulumi/pulumi-azure/actions/runs/10845914340/job/30097763444 - go fails because it's a prerelease being tested, but we can't skip it yet when invoking directly (see pulumi/ci-mgmt#1080)
thomas11
approved these changes
Sep 13, 2024
provider-ci/internal/pkg/templates/provider/.github/workflows/verify-release.yml
Outdated
Show resolved
Hide resolved
danielrbradley
force-pushed
the
skip-go-verification-on-dispatch
branch
from
7b227ae
to
2bb9cbb
Compare
flostadler
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't test Go SDKs for pre-releases because we don't publish the Go SDKs for them. This is already implemented when invoked via a workflow_call, but the option wasn't available when using a workflow_dispatch (manual run).