Ability to disable publishing to the Pulumi CDN #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I apologize for the question, but what is Pulumi CDN? This looks reasonable to me otherwise - I would like to see a third-party provider test in the repo maybe, so we can see the applied changes alongside the PR. |
|
@guineveresaenger I updated the initial comment. Pulumi CDN is This commit uses this setting for the Pulumiverse ACME provider. Besides setting the property, it is a no-op because I had removed these steps manually from the setup before. pulumiverse/pulumi-acme@687dedc Should I mimic the acme setup under the |
danielrbradley
approved these changes
Sep 13, 2024
provider-ci/internal/pkg/templates/bridged-provider.config.yaml
Outdated
Show resolved
Hide resolved
ringods
force-pushed
the
configure-publish-to-cdn
branch
from
3b147e8
to
fa9eca6
Compare
|
@guineveresaenger |
…d providers Co-authored-by: Daniel Bradley <[email protected]>
ringods
force-pushed
the
configure-publish-to-cdn
branch
from
fa9eca6
to
82af599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to disable publishing to the Pulumi CDN (
get.pulumi.com) for non-Pulumi managed providers.Ran
make test-providerswhich didn't render any changes, but it worked for mypulumiverse/pulumi-acmeprovider.