-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset background image to fit container #11485: Update dashboard.css #11559
Conversation
background-size changed from cover to contain, background-repeat and background-position added at .dashboard .dashboard-blog .img, from line 126 to 130
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 19f0106 and detected 0 issues on this pull request. View more on Code Climate. |
Hello @publiclab/reviewers! Here is my first contribution, I wait for your review, thank you a lot! |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11559 +/- ##
==========================================
+ Coverage 83.21% 83.33% +0.12%
==========================================
Files 93 93
Lines 5772 5772
==========================================
+ Hits 4803 4810 +7
+ Misses 969 962 -7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @victoria-parker, can you add it to this style instead https://github.com/publiclab/plots2/blob/main/app/views/dashboard_v2/dashboard.html.erb#L46-L48?
Thanks!
Hello @TildaDares ! Yes sure! |
Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add |
Hello! This is my first contribution. background-size changed from cover to contain, background-repeat:no-repeat; and background-position:center; added at .dashboard .dashboard-blog .img, from line 126 to 130
Fixes #11485 (#11485)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below