Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some comments #1052

Merged
merged 2 commits into from
Jun 7, 2024
Merged

chore: fix some comments #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ecf427
chore: fix some comments
costcould Jun 5, 2024
85addb4
Merge branch 'main' into main
jhernandezb Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x/cron/keeper/msg_server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func TestDemoteFromPrivilegedContract(t *testing.T) {
true,
},
{
"contract curretly does not have privilege to demote it",
"contract currently does not have privilege to demote it",
func(ctx sdk.Context, keeper keeper.Keeper) *types.MsgDemoteFromPrivilegedContract {
govModuleAddr := keeper.GetAuthority()
msg := types.MsgDemoteFromPrivilegedContract{
Expand Down
6 changes: 3 additions & 3 deletions x/cron/keeper/privileged_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
func Test_SetPrivileged(t *testing.T) {
k, ctx := keeper.CronKeeper(t)

// contract doesnt exist
// contract doesn't exist
acc1 := sample.AccAddress()
err := k.SetPrivileged(ctx, acc1)
if err == nil {
Expand All @@ -29,14 +29,14 @@ func Test_SetPrivileged(t *testing.T) {
func Test_UnsetPrivileged(t *testing.T) {
k, ctx := keeper.CronKeeper(t)

// contract doesnt exist
// contract doesn't exist
acc1 := sample.AccAddress()
err := k.UnsetPrivileged(ctx, acc1)
if err == nil {
t.Errorf("expected %s to not exist, and fail to set privilege", acc1)
}

// contract exists but doesnt have privilege
// contract exists but doesn't have privilege
acc2 := sdk.MustAccAddressFromBech32("cosmos1qyqszqgpqyqszqgpqyqszqgpqyqszqgpjnp7du")
err = k.UnsetPrivileged(ctx, acc2)
if err == nil {
Expand Down
2 changes: 1 addition & 1 deletion x/globalfee/keeper/code_authorization_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func Test_CodeAuthorization(t *testing.T) {
require.Error(t, err)
})

t.Run("authorization doesnt exist", func(t *testing.T) {
t.Run("authorization doesn't exist", func(t *testing.T) {
found := k.HasCodeAuthorization(ctx, ca.CodeID)
require.False(t, found)
})
Expand Down
2 changes: 1 addition & 1 deletion x/globalfee/keeper/contract_authorization_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func Test_ContractAuthorization(t *testing.T) {
require.Error(t, err)
})

t.Run("authorization doesnt exist", func(t *testing.T) {
t.Run("authorization doesn't exist", func(t *testing.T) {
found := k.HasContractAuthorization(ctx, sdk.MustAccAddressFromBech32(ca.ContractAddress))
require.False(t, found)
})
Expand Down
2 changes: 1 addition & 1 deletion x/globalfee/keeper/msg_server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ func TestSetContractAuthorization(t *testing.T) {
true,
},
{
"contract doesnt exist",
"contract doesn't exist",
func(ctx sdk.Context, keeper keeper.Keeper) *types.MsgSetContractAuthorization {
sender := sample.AccAddress()
params := types.NewParams([]string{sender.String()})
Expand Down
Loading