Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-stackdriver-exporter] fix deployment annotations #4767

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

wsmolkowski
Copy link

@wsmolkowski wsmolkowski commented Aug 2, 2024

What this PR does / why we need it

fix #4768

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: Wojciech Smołkowski <[email protected]>
Signed-off-by: Wojciech Smołkowski <[email protected]>
@wsmolkowski wsmolkowski changed the title fix deployment annotations [prometheus-couchdb-exporter] fix deployment annotations Aug 2, 2024
@wsmolkowski wsmolkowski changed the title [prometheus-couchdb-exporter] fix deployment annotations [prometheus-stackdriver-exporter] fix deployment annotations Aug 2, 2024
rpahli
rpahli previously approved these changes Aug 6, 2024
@wsmolkowski
Copy link
Author

@rpahli when could you merge it?

@rpahli
Copy link
Member

rpahli commented Aug 26, 2024

@wsmolkowski there are still build error. Can you pls fix the build, then we can merge your PR.

@rpahli
Copy link
Member

rpahli commented Sep 13, 2024

@wsmolkowski any update on this? can you pls fix the lint error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-stackdriver-exporter] Deployment metadata missing annotations
3 participants