Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prom-label-proxy] Add svc annotations support #3581

Merged
merged 2 commits into from
Jul 11, 2023
Merged

[prom-label-proxy] Add svc annotations support #3581

merged 2 commits into from
Jul 11, 2023

Conversation

7840vz
Copy link
Contributor

@7840vz 7840vz commented Jul 11, 2023

What this PR does / why we need it

Which issue this PR fixes

  • Add prom-label-proxy service annotations support mentioned in default values.yaml

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@7840vz 7840vz requested a review from jkroepke as a code owner July 11, 2023 15:20
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jkroepke jkroepke merged commit 3cc956d into prometheus-community:main Jul 11, 2023
4 checks passed
@7840vz 7840vz deleted the prom-label-proxy-svc-annotations branch July 11, 2023 19:26
Matiasmct pushed a commit to giffgaff/prometheus-charts that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants