[prometheus-pingdom-exporter] Add support for Serviceaccount Volume and VolumeMount #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolumeMounts Signed-off-by: Danny Lyubenov <[email protected]> Signed-off-by: Danny Lyubenov <[email protected]>
DannyLyubenov
force-pushed
the
feature/add-volumes-and-serviceaccount
branch
from
51c4196
to
dd6160c
Compare
rpahli
approved these changes
Jul 6, 2023
|
Hi Rico (@rpahli) thank you for approving my PR, is there anything else that needs to be done before it gets merged? Many thanks |
monotek
requested changes
Jul 10, 2023
monotek
reviewed
Jul 10, 2023
monotek
approved these changes
Jul 10, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
Aug 25, 2023
…nd (prometheus-community#3555) VolumeMounts Signed-off-by: Danny Lyubenov <[email protected]> Signed-off-by: Danny Lyubenov <[email protected]> Co-authored-by: Danny Lyubenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
There is the need to extract secrets from Vault for the Pingdom account and we are using the Vault CSI driver which needs to mount the volume onto the container. To achieve this we need to extend the chart to create
ServiceAccount,VolumeandVolumeMountsWhich issue this PR fixes
N/A
Special notes for your reviewer
Hi @monotek and @rpahli could you please review the chart when you have a moment
Checklist
[prometheus-couchdb-exporter])