Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): add .dockerignore #5636

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

chore(docker): add .dockerignore #5636

wants to merge 4 commits into from

Conversation

dwisiswant0
Copy link
Member

@dwisiswant0 dwisiswant0 commented Sep 16, 2024 •
edited
Loading

Proposed changes

  • Update GOBUILD outputs in make
  • Single-stage build docker image
  • Symlink .dockerignore to .gitignore

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dwisiswant0 dwisiswant0 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Sep 16, 2024
@Mzack9999
Copy link
Member

Wouldn't this increase the size of the final docker image with all the build tools presence?
Screenshot 2024-09-16 at 18 24 39

@dwisiswant0 dwisiswant0 changed the title chore(docker): single-stage build chore(docker): add .dockerignore Sep 20, 2024
@dwisiswant0
Copy link
Member Author

Wouldn't this increase the size of the final docker image with all the build tools presence?

Yeah, you were right. Reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

@dogancanbakir dogancanbakir Awaiting requested review from dogancanbakir

Assignees
No one assigned
Labels
Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwisiswant0 @Mzack9999