New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY out the CircleCI configuration #406

Merged

zestyping merged 2 commits into dev from schuyler/ci-refactor

Aug 18, 2019

Member

schuyler commented Jul 11, 2019

This PR has been split out from #402 for simplicity and clarity.

Refactor CircleCI configuration using YAML references to eliminate repeated stanzas. Note that this is inspired by what ODK Collect is doing.
Bump CircleCI build image to Android API 28, since that's what Gradle is using.

schuyler added 2 commits

July 11, 2019 10:27


          Refactor CircleCI configuration to DRY with YAML references.

1b16ab8


          Use API 28 in CircleCI because that's actually what Gradle is expecting.

d4a6b2a

schuyler requested a review from zestyping

July 11, 2019 17:33

This was referenced Jul 11, 2019

Add version numbering to dev builds #402

Open

WIP: Run instrumentation tests in Firebase Test Lab #407

Open

zestyping approved these changes

View reviewed changes

Contributor

zestyping left a comment

Sorry it took me a while to get to this. I understand what's happening here now and it seems fine.

zestyping merged commit a4a749e into dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet