Profile Manager Error Handling #14
Conversation
…Profile Manager. Other refactoring was made to improve profiles.jsp readability. Also was introduced the ability to setup a custom path for the profile storage folder. The custom folder configuration must be in openmrs-runtime.properties under profile_manager.profile_dir. This changes is related to issue #12.
|
This will be difficult to understand diff. I think, to better understand the work is to read the files separately like a before and after compare. |
|
To test the error messages simply do a new dev env setup and see Profile Manager output the problems that it finds regarding things that are missing like the folder, permissions, missing scripts, etc. |
|
To set a custom profile directory now we have the option to set the profile_manager.profile_dir directive in openmrs-runtime.properties: profile_manager.profile_dir=/usr/share/buendia/profilesThis is not mandatory. Profile Manager will use the default directory if no custom is set. |
|
Good call on adding the configuration property, Leonardo! I like this solution to the Mac vs. Linux problem. I've made a few other comments; please have a look. |
| private File profileDir; | ||
|
|
||
| @ModelAttribute | ||
| public void getInitializedMyObject() { |
There was a problem hiding this comment.
It's not obvious how or when this method gets called. How about making this a getter instead, i.e. public File getProfileDir()?
There was a problem hiding this comment.
Yes. Sorry, I forgot to change the name of the method!
| import java.util.List; | ||
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
| import java.util.*; |
There was a problem hiding this comment.
I would suggest you to import the specific classes.
There was a problem hiding this comment.
I didn't notice that. Again I blame IntelliJ. But I wonder why it did this. I'll look into that.
There was a problem hiding this comment.
There's a setting in IntelliJ for this under Preferences > Code Style > Java on the "Imports" tab, named "Class count to use import with '*'".
The settings file at https://github.com/projectbuendia/buendia/blob/dev/intellij-idea-settings.jar should fix this too — it sets the class count to 99 so that import with * is basically never used.
There was a problem hiding this comment.
OK. I fixed it.
| @@ -108,7 +136,7 @@ public View post(HttpServletRequest request, HttpServletResponse response, Model | |||
| } | |||
|
|
|||
| /** Chooses a filename based on the given name, with a "-vN" suffix appended for uniqueness. */ | |||
| String getNextVersionedFilename(String name) { | |||
| private String getNextVersionedFilename(String name) { | |||
There was a problem hiding this comment.
private methods should be after public ones.
|
@llvasconcellos, did you import the project's settings ( |
| List<FileInfo> files = new ArrayList<>(); | ||
| for (File file : PROFILE_DIR.listFiles()) { | ||
| files.add(new FileInfo(file)); | ||
| String currentProfile = Context.getAdministrationService().getGlobalProperty(GlobalProperties.CURRENT_PROFILE); |
There was a problem hiding this comment.
I just noticed, although you didn't change this either, you could use getCurrentProfile() here if you want.
|
Thanks for the quick response, Leonardo! |
|
@llvasconcellos, combining these two PRs #14 and #15, the profile was successfully imported on a mac environment set up from scratch. |
|
@viniciusboson No, I did not import the settings. I'm doing it right now. Thanks for reminding me and thanks for your input on the Mac side of the force! |
…file-manager-error-handling Profile Manager Error Handling
In depth refactoring for better error handling and displaying on the Profile Manager.
Other refactoring was made to improve profiles.jsp readability.
Also was introduced the ability to setup a custom path for the profile storage folder.
The custom folder configuration must be in openmrs-runtime.properties under profile_manager.profile_dir.
This changes is related to issue #12.