Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified MarketplaceMonitorDaemon to optionally run in single mode. #517

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

wlara
Copy link
Collaborator

@wlara wlara commented Aug 7, 2024

No description provided.

@AndrewWestberg
Copy link
Member

@wlara What happens if we end up monitoring from both running instances at the same time? My code kinda/sorta still works since it's relying on SQS queues which (in theory but not in practice), only get delivered to a single instance.

@wlara
Copy link
Collaborator Author

wlara commented Aug 7, 2024

@wlara What happens if we end up monitoring from both running instances at the same time? My code kinda/sorta still works since it's relying on SQS queues which (in theory but not in practice), only get delivered to a single instance.

That's a problem. Single-mode is intended as a short term solution to enable testing in the garage environment. By the time we deploy the smart contracts in mainnet, we need to enable multi-mode and have Zookeeper running.

@wlara wlara merged commit 753b0f4 into master Aug 7, 2024
2 checks passed
@wlara wlara deleted the wlara/mp-monitor-fix branch August 7, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants