STUD-294: Use LeaderLatch for SQS receiving #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlara
approved these changes
Jul 31, 2024
wlara
reviewed
Jul 31, 2024
| @@ -19,20 +19,29 @@ import kotlin.reflect.full.primaryConstructor | |||
| import kotlinx.coroutines.cancelChildren | |||
| import kotlinx.coroutines.delay | |||
| import kotlinx.coroutines.launch | |||
| import org.apache.curator.framework.recipes.leader.LeaderLatch | |||
There was a problem hiding this comment.
We'll need to wait until the Zookeeper issues are fixed, before merging this.
Or maybe you can add a config flag to enable/ disable usage of the Leader latch in this Daemon
There was a problem hiding this comment.
I have adjusted the code so that if the curator is disabled, the code assumes it is the leader and works the same as before.
AndrewWestberg
force-pushed
the
amw/STUD-294
branch
from
02d0840
to
45d9762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.