minor: STUD-196 Implement "Released" email notification #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlara
reviewed
Jul 21, 2024
newm-server/src/main/kotlin/io/newm/server/features/scheduler/OutletReleaseStatusJob.kt
Outdated
Show resolved
Hide resolved
wlara
reviewed
Jul 21, 2024
newm-server/src/main/kotlin/io/newm/server/config/repo/ConfigRepository.kt
Outdated
Show resolved
Hide resolved
saif-software-developer
force-pushed
the
feature/STUD-196
branch
from
9a4e4d3
to
61aef2d
Compare
wlara
reviewed
Jul 22, 2024
wlara
reviewed
Jul 22, 2024
newm-server/src/main/kotlin/io/newm/server/features/release/repo/OutletReleaseRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
wlara
reviewed
Jul 22, 2024
newm-server/src/main/kotlin/io/newm/server/features/scheduler/OutletReleaseStatusJob.kt
Outdated
Show resolved
Hide resolved
saif-software-developer
force-pushed
the
feature/STUD-196
branch
2 times, most recently
from
f13ecb1
to
2f7bbee
Compare
saif-software-developer
force-pushed
the
feature/STUD-196
branch
from
2f7bbee
to
29d1ebb
Compare
saif-software-developer
force-pushed
the
feature/STUD-196
branch
2 times, most recently
from
53bfa3c
to
53ef8ab
Compare
|
@saif-software-developer Looks good to me, but I'll let @wlara give final approval on this one. |
wlara
requested changes
Jul 25, 2024
There was a problem hiding this comment.
@saif-software-developer You need to check-in the mint-released.mjml file into the src/main/mjml/email directory.
Also, please update the screenshot to check how the final version looks like.
saif-software-developer
force-pushed
the
feature/STUD-196
branch
from
53ef8ab
to
cee7d94
Compare
wlara
reviewed
Jul 25, 2024
wlara
reviewed
Jul 25, 2024
wlara
reviewed
Jul 25, 2024
saif-software-developer
force-pushed
the
feature/STUD-196
branch
5 times, most recently
from
9561413
to
33897ba
Compare
fix: STUD-291 fixed merge issue minor: STUD-196 update email template for song released minor: STUD-196 removed TODO message minor: STUD-196 added mint-released.mjml file fix: STUD-196 updated mint-released.mjml file fix: STUD-196 updated mint-released.html file fix: STUD-196 updated mint-released.html file fix: STUD-196 updated mint-released.html file fix: STUD-196 updated mint-released.html file fix: STUD-196 updated mint-released.html file
saif-software-developer
force-pushed
the
feature/STUD-196
branch
from
33897ba
to
7128b8c
Compare
|
Tested: |
wlara
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge