Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial launcher redesign #36

Merged
merged 14 commits into from
Oct 2, 2024
Merged

Initial launcher redesign #36

merged 14 commits into from
Oct 2, 2024

Conversation

TheSpartaPT
Copy link
Collaborator

Initial Launcher redesign

@TheSpartaPT
Initial launcher commit
eb5b630 
- Launcher redesigned
- A lot will probably need to change in the future
@seionmoya seionmoya added enhancement New feature or request launcher Related to Fuyu.Launcher labels Sep 17, 2024
seionmoya
seionmoya requested changes Sep 17, 2024
View reviewed changes
Fuyu.Launcher/Components/AddGameDialog.razor Outdated Show resolved Hide resolved
Fuyu.Launcher/Components/AddGameDialog.razor Outdated Show resolved Hide resolved
Fuyu.Launcher/Components/AddGameDialog.razor Outdated Show resolved Hide resolved
Fuyu.Launcher/Components/AddGameDialog.razor Outdated Show resolved Hide resolved
Fuyu.Launcher.Core/Services/RequestService.cs Outdated Show resolved Hide resolved
Fuyu.Launcher/Components/Game.razor Show resolved Hide resolved
Fuyu.Backend.Core/Services/AccountService.cs Outdated Show resolved Hide resolved
Fuyu.Launcher.Core/Services/RequestService.cs Outdated Show resolved Hide resolved
Fuyu.Launcher.Core/Services/RequestService.cs Outdated Show resolved Hide resolved
Fuyu.Launcher/Components/AboutDialog.razor Outdated Show resolved Hide resolved
@seionmoya
Copy link
Collaborator

That's the initial review, I'll review everything once the first changes have been made. Thank you for your hard work @TheSpartaPT. it's really appriciated!

@TheSpartaPT TheSpartaPT changed the title Initial launcher commit Initial launcher redesign Sep 17, 2024
MerijnHendriks
MerijnHendriks suggested changes Sep 24, 2024
View reviewed changes
Copy link

@MerijnHendriks MerijnHendriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second part of the review, might have overlooked one or two cases but you should get the gist of it. Thanks for your patience!

Fuyu.Backend.Core/Controllers/AccountGamesController.cs Show resolved Hide resolved
Fuyu.Backend.Core/Controllers/AccountLogoutController.cs Outdated Show resolved Hide resolved
Fuyu.Launcher.Core/Services/RequestService.cs Outdated Show resolved Hide resolved
Fuyu.Launcher.Core/Services/RequestService.cs Show resolved Hide resolved
Fuyu.Launcher/Components/AboutDialog.razor Outdated Show resolved Hide resolved
Fuyu.Launcher/Store/GetGamesResultAction.cs Outdated Show resolved Hide resolved
Fuyu.Launcher/Store/LogoutSessionAction.cs Outdated Show resolved Hide resolved
Fuyu.Launcher/Store/SessionUseCase/Reducers.cs Outdated Show resolved Hide resolved
Fuyu.Launcher/Store/SessionUseCase/SessionState.cs Outdated Show resolved Hide resolved
Fuyu.Launcher/Store/SessionUseCase/SessionState.cs Show resolved Hide resolved
@seionmoya seionmoya merged commit 461365c into project-fika:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerijnHendriks MerijnHendriks MerijnHendriks requested changes

@seionmoya seionmoya seionmoya approved these changes

Assignees

@TheSpartaPT TheSpartaPT

Labels
enhancement New feature or request launcher Related to Fuyu.Launcher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSpartaPT @seionmoya @MerijnHendriks