Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ray Cluster Upgrade test of Ray Job Long Running scenarios #614

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented Jul 31, 2024

Issue link

https://issues.redhat.com/browse/RHOAIENG-10118

What changes have been made

Added Ray Job submission use case in Pre upgrade test TestMNISTRayClusterUp and added check to verify that Ray job exists in ray cluster in post upgrade test TestMnistJobSubmit

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2024
@Srihari1192
Copy link
Contributor Author

Tests are looks good here /job/rhods-ci-pr-test/3193/

@Srihari1192 Srihari1192 marked this pull request as ready for review August 1, 2024 05:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2024
@abhijeet-dhumal
Copy link
Contributor

Ran through the tests and confirmed that it works as expected.. Thanks!
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@Srihari1192 Srihari1192 marked this pull request as draft August 7, 2024 04:55
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@Srihari1192 Srihari1192 changed the title Update Ray Cluster Upgrade tests to cover Ray Job Submission scenarios Add Ray Cluster Upgrade test of Ray Job Long Running scenarios Aug 7, 2024
@Srihari1192 Srihari1192 marked this pull request as ready for review August 8, 2024 07:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhijeet-dhumal, sutaakar
Once this PR has been reviewed and has the lgtm label, please assign franciscojavierarceo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Srihari1192 Srihari1192 merged commit 4017d8b into project-codeflare:main Aug 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants