Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PR check for guided notebooks #595

Merged

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jul 18, 2024

Issue link

RHOAIENG-10262

What changes have been made

Added PR check which alters and executes guided notebooks using built CodeFlare SDK.
Notebooks are executed using Papermill package.

PR check is triggered by labeling a PR with test-guided-notebooks label.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2024
@sutaakar sutaakar force-pushed the guided-notebooks branch 24 times, most recently from 0633a35 to de0464b Compare July 24, 2024 10:59
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
@sutaakar sutaakar force-pushed the guided-notebooks branch 2 times, most recently from 28fd5eb to 14cc729 Compare July 25, 2024 13:39
@sutaakar sutaakar force-pushed the guided-notebooks branch 8 times, most recently from e288940 to f197921 Compare July 26, 2024 10:10
@sutaakar sutaakar added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Jul 26, 2024
@sutaakar sutaakar added the test-guided-notebooks Run PR check to verify Guided notebooks label Jul 26, 2024
@sutaakar sutaakar marked this pull request as ready for review July 26, 2024 10:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2024
@astefanutti
Copy link
Contributor

/lgtm

Awesome!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2024
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ecf04c3 into project-codeflare:main Jul 26, 2024
13 checks passed
@sutaakar sutaakar deleted the guided-notebooks branch July 26, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. test-guided-notebooks Run PR check to verify Guided notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants