-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide cjs and esm builds #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipebergamin
force-pushed
the
chore/update-apollo-libs
branch
from
August 30, 2023 16:46
5c7a7fb
to
db8019a
Compare
felipebergamin
force-pushed
the
feat/esm-and-cjs-builds
branch
from
August 30, 2023 16:46
278a2a3
to
9a70ac1
Compare
felipebergamin
force-pushed
the
chore/update-apollo-libs
branch
from
August 30, 2023 17:17
db8019a
to
a419dfb
Compare
felipebergamin
force-pushed
the
feat/esm-and-cjs-builds
branch
2 times, most recently
from
August 30, 2023 18:29
f161920
to
ba85f17
Compare
felipebergamin
force-pushed
the
chore/update-apollo-libs
branch
from
August 30, 2023 18:50
a419dfb
to
41bcde9
Compare
felipebergamin
force-pushed
the
feat/esm-and-cjs-builds
branch
from
August 30, 2023 18:59
ba85f17
to
46666ff
Compare
felipebergamin
force-pushed
the
chore/update-apollo-libs
branch
from
August 31, 2023 14:44
0d4d9b5
to
d9a3b52
Compare
felipebergamin
force-pushed
the
feat/esm-and-cjs-builds
branch
from
August 31, 2023 14:55
46666ff
to
9d28785
Compare
felipebergamin
force-pushed
the
chore/update-apollo-libs
branch
from
August 31, 2023 21:56
d9a3b52
to
33a4598
Compare
felipebergamin
force-pushed
the
feat/esm-and-cjs-builds
branch
from
August 31, 2023 22:05
9d28785
to
118e75b
Compare
felipebergamin
requested review from
barbieri,
YasminBeatriz and
DDDKnightmare
August 31, 2023 22:13
felipebergamin
force-pushed
the
chore/update-apollo-libs
branch
from
September 1, 2023 19:29
33a4598
to
6938e11
Compare
felipebergamin
force-pushed
the
feat/esm-and-cjs-builds
branch
from
September 1, 2023 19:42
118e75b
to
0ad32b8
Compare
DDDKnightmare
previously approved these changes
Sep 1, 2023
felipebergamin
force-pushed
the
chore/update-apollo-libs
branch
from
September 4, 2023 17:22
120bfd7
to
617f0e2
Compare
felipebergamin
force-pushed
the
feat/esm-and-cjs-builds
branch
from
September 4, 2023 17:27
0ad32b8
to
ec15a4e
Compare
felipebergamin
force-pushed
the
chore/update-apollo-libs
branch
from
September 11, 2023 17:42
617f0e2
to
0117d00
Compare
- Provide cjs and esm distributions under build/(esm|cjs) dirs - Generate .d.ts files under build/types
felipebergamin
force-pushed
the
feat/esm-and-cjs-builds
branch
from
September 11, 2023 17:46
ec15a4e
to
8280ddc
Compare
felipebergamin
dismissed
DDDKnightmare’s stale review
September 13, 2023 11:18
The base branch was changed.
DDDKnightmare
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
exports
entry to package.json pointing to the correct entry file depending on which module system is being used.js
file extension, as required for esmodules"type": "commonjs"
is required for commonjs distribution, so a script is invoked to create this file under build/cjs to make it work for cjs projects.Related Issues
Progress
Pull request checklist
How to test it
Visual reference