Implement Bank Select Buttons and MIDI Buttons #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #736
Implements buttons and MIDI buttons via the following additional config items in minidexed.ini
Needs testing for following cases:
PerformanceSelectChannel=0
- i.e. selecting Voice BanksPerformanceSelectChannel!=0
- i.e. selecting Performance BanksPerformanceSelectChannel=0
- i.e. selecting Voice Banks over MIDIPerformanceSelectChannel!=0
- i.e. selecting Performance Banks over MIDINote: this does not depend on the setting of
PerformanceSelectToLoad
- if operating on performance banks then they are always automatically loaded and selected when using buttons or MIDI buttons for selecting. Nothing else made sense to me as there is no "scroll then load" type action going on as would be the case via the UI itself.Also, when a bank changes, the first voice/performance is automatically loaded. This might cause a bit of a delay when moving through performances maybe as I think loading performances can be a little slow...? Lets see how people get on...
So if anyone fancies giving it a go with the above configuration but also with your existing configs please do.
Kevin