Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove actor system for transactions, refactor iTX and tracing #5001

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Sep 21, 2024

This reverts commit e1242e1 and re-applies #4940.

Integration: prisma/prisma#25285

Fixes: https://github.com/prisma/team-orm/issues/1270
Fixes: prisma/prisma#23792
Fixes: #4336
Closes: https://github.com/prisma/team-orm/issues/1285

/integration

@aqrln aqrln added this to the 5.20.0 milestone Sep 21, 2024
@aqrln aqrln self-assigned this Sep 21, 2024
@aqrln aqrln changed the title fix: remove actor system for transactions fix: remove actor system for transactions, refactor iTX and tracing Sep 21, 2024
Copy link
Contributor

github-actions bot commented Sep 21, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.691MiB 2.708MiB -17.279KiB
Postgres (gzip) 1.029MiB 1.036MiB -7.263KiB
Mysql 2.019MiB 2.035MiB -16.087KiB
Mysql (gzip) 805.691KiB 812.539KiB -6.848KiB
Sqlite 1.913MiB 1.928MiB -15.750KiB
Sqlite (gzip) 764.761KiB 770.435KiB -5.674KiB

Copy link

codspeed-hq bot commented Sep 21, 2024

CodSpeed Performance Report

Merging #5001 will not alter performance

Comparing integration/itx-refactor (4c3d818) with main (031f4d3)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno assigned jkomyno and unassigned jkomyno Sep 23, 2024
@jkomyno
Copy link
Contributor

jkomyno commented Sep 23, 2024

I'm waiting for #5003 before being able to release a new integration version.

@aqrln aqrln force-pushed the integration/itx-refactor branch 3 times, most recently from 26f089d to e76b742 Compare September 25, 2024 14:15
@aqrln aqrln modified the milestones: 5.20.0, 5.21.0 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some prisma:engine:connection spans have no parent
3 participants