-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: timed out fetching a new connection from the connection pool. #4998
Open
youxq
wants to merge
3
commits into
prisma:main
Choose a base branch
from
youxq:fix/tls-builder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this ready to merge? |
Thanks so much for the PR and sorry for the delay, I'll get to it soon (tomorrow or early next week). |
CodSpeed Performance ReportMerging #4998 will not alter performanceComparing Summary
|
youxq
force-pushed
the
fix/tls-builder
branch
from
September 29, 2024 03:13
d0d7720
to
da82b63
Compare
I have fixed the lint issue. Please help trigger the checks workflow again. Thanks. |
Would love to see this merged |
anton-ax
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix (prisma/prisma#25162)
solution
Change
new MakeTlsConnector
, which is executed by eachPostgreSql::new
, to obtain it fromMakeTlsConnectorManager.get_connector
. The logic ofget_connector
is to createnew MakeTlsConnector
in the first call and save the created tls connector. All subsequent calls will clone the tls connector from the first call, thereby reducing the overhead of thenew MakeTlsConnector
.test results
Use https://github.com/youxq/prisma-connection-test tool to test.
The bug of
Timed out fetching a new connection from the connection pool.
was successfully triggered before the fix.It no longer appears after the fix.