Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query-engine): use @map'd values of enum in query input and output #4987

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Aug 23, 2024

DRAFT, still experimental.

This PR contributes to prisma/prisma#8446 and prisma/prisma#273.
This PR introduces a breaking change, let's wait for Prisma 6.


ba87944 can be extracted into its own PR, as it fixes a prisma validate bug internally discovered here.

@jkomyno jkomyno self-assigned this Aug 23, 2024
@jkomyno jkomyno requested a review from a team as a code owner August 23, 2024 23:40
@jkomyno jkomyno requested review from Weakky and removed request for a team and Weakky August 23, 2024 23:40
Copy link

codspeed-hq bot commented Aug 23, 2024

CodSpeed Performance Report

Merging #4987 will not alter performance

Comparing integration/enum-mapped-values (ba87944) with main (0bc306e)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.063MiB 2.063MiB 737.000B
Postgres (gzip) 824.122KiB 823.738KiB 393.000B
Mysql 2.033MiB 2.033MiB 732.000B
Mysql (gzip) 811.536KiB 811.288KiB 254.000B
Sqlite 1.924MiB 1.924MiB 741.000B
Sqlite (gzip) 769.014KiB 768.296KiB 735.000B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant