feat(schema-wasm): support edge runtimes in addition to Node.js #4950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4950 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
Previously we generated wasm-bindgen bindings for `@prisma/prisma-schema-wasm` with `--target nodejs`. This makes the generated glue code use Node.js `fs` module to load the WebAssembly module from disk and then instantiate it from an array of bytes. This commit change this to `--target bundler` which is what we use for `query-engine-wasm`. This makes wasm-bindgen use `import` statement to load the WebAssembly module instead. This is a breaking change, and requires updating Prisma CLI and language tools.
aqrln
force-pushed
the
integration/schema-wasm-bundler
branch
from
816ba4d
to
2ffa63f
Compare
aqrln
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we generated wasm-bindgen bindings for
@prisma/prisma-schema-wasmwith--target nodejs. This makes the generated glue code use Node.jsfsmodule to load the WebAssembly module from disk and then instantiate it from an array of bytes.This commit change this to
--target bundlerwhich is what we use forquery-engine-wasm. This makes wasm-bindgen useimportstatement to load the WebAssembly module instead.This is a breaking change, and requires updating Prisma CLI and language tools.