fix: DPS-292 fixes externalPayerInfo on Paypal #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semirp
approved these changes
Apr 24, 2024
Generated by 🚫 Danger Swift against 18674bd |
|
Appetize link: https://appetize.io/app/orfusvkm6pgjx5rwlwpnuhanta |
jnewc
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DPS-292
This change mirrors
externalPayerId,firstNameandlastNameto their snake case counterparts. Note that the mirroring is necessary due to the fact that the API expects these values in snake case, but returns them in camelCase. See here:Manual Testing
Make a paypal payment, and check that External Payer ID, first name, and last name is set on the payment.