Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix warnings in SDK and debug app #847

Merged
merged 1 commit into from
Apr 24, 2024
Merged

chore: Fix warnings in SDK and debug app #847

merged 1 commit into from
Apr 24, 2024

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Apr 24, 2024

Description

Some warning fixes. This PR is intended to test SonarCloud.

Contributor Checklist

  • All status checks have passed prior to code review
  • I have added unit tests to a reasonable level of coverage where suitable
  • I have added UI tests to new user flows, if applicable
  • I have manually tested newly added UX
  • I have open a documentation PR, if applicable

Reviewer Checklist

  • I have verified that a suitable set of automated tests has been added
  • I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR
  • I have verified the documentation PR aligns with this PR, if applicable

Before Merging

  • If introducing a breaking change, I have communicated it internally
  • Any related documentation PRs are ready to merge

Other Stuff

  • You can find out more about our automation checks here
  • Find out more about conventional commits here

@jnewc jnewc changed the title chore: Fix warning in SDK and debug app chore: Fix warnings in SDK and debug app Apr 24, 2024
Copy link
Contributor

github-actions bot commented Apr 24, 2024

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against c77cb6a

Copy link
Contributor

@jnewc jnewc merged commit 1c19ef9 into master Apr 24, 2024
8 of 10 checks passed
@jnewc jnewc deleted the jn/fix-warnings branch April 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants