primer-io · jnewc · Apr 23, 2024 · Apr 23, 2024 · Apr 23, 2024 · Apr 23, 2024
@@ -16,7 +16,15 @@ jobs:
         with:
           fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
       - name: SonarCloud Scan
-        uses: SonarSource/sonarcloud-github-action@master
+        uses: sonarsource/sonarqube-scan-action@master
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+          SONAR_HOST_URL: https://sonarcloud.io./
+      - name: SonarQube Quality Gate check
+        id: sonarqube-quality-gate-check
+        uses: sonarsource/sonarqube-quality-gate-action@master
+        timeout-minutes: 5
+        env:
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+          SONAR_HOST_URL: https://sonarcloud.io./
@@ -34,11 +34,6 @@
                BlueprintName = "PrimerSDKTests"
                ReferencedContainer = "container:">
             </BuildableReference>
-            <SkippedTests>
-               <Test
-                  Identifier = "HUC_TokenizationViewModelTests">
-               </Test>
-            </SkippedTests>
          </TestableReference>
       </Testables>
    </TestAction>

@@ -29,7 +29,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
                      restorationHandler: @escaping ([UIUserActivityRestoring]?) -> Void) -> Bool {
         if let url = userActivity.webpageURL {
             let handled = AppetizeUrlHandler.handleUrl(url)
-            if handled == true {
+            if handled {
                 return handled
             }
         }

@@ -433,7 +433,7 @@ struct ClientSessionRequestBody {
                     dic["extraMerchantData"] = extraMerchantData
                 }
 
-                if let captureVaultedCardCvv = captureVaultedCardCvv, captureVaultedCardCvv == true {
+                if let captureVaultedCardCvv = captureVaultedCardCvv, captureVaultedCardCvv {
                     dic["captureVaultedCardCvv"] = captureVaultedCardCvv
                 }
 

@@ -24,7 +24,7 @@ class AppetizeConfigProvider {
     }
 
     func fetchConfig() -> SessionConfiguration? {
-        guard payloadProvider.isAppetize == true,
+        guard let isAppetize = payloadProvider.isAppetize, isAppetize,
               let jwt = payloadProvider.configJwt,
               let config = getConfig(from: jwt) else {
             return nil

@@ -445,7 +445,7 @@ class MerchantSessionAndSettingsViewController: UIViewController {
     func populateSessionSettingsFields() {
         clientSession = MerchantMockDataManager.getClientSession(sessionType: paymentSessionType)
 
-        enableCVVRecaptureFlowSwitch.isOn = clientSession.paymentMethod?.options?.PAYMENT_CARD?.captureVaultedCardCvv == true
+        enableCVVRecaptureFlowSwitch.isOn = clientSession.paymentMethod?.options?.PAYMENT_CARD?.captureVaultedCardCvv ?? false
 
         currencyTextField.text = clientSession.currencyCode?.code
         countryCodeTextField.text = clientSession.order?.countryCode?.rawValue

@@ -39,7 +39,7 @@ internal class Connectivity {
         if needsConnection { return .none }
         if !isReachable { return .none }
 
-        if flags.contains(.isWWAN) == true {
+        if flags.contains(.isWWAN) {
             return .cellular
         } else {
             return .wifi

@@ -449,7 +449,7 @@ final class BanksTokenizationComponent: NSObject, LogReporter {
 
     func handleDecodedClientTokenIfNeeded(_ decodedJWTToken: DecodedJWTToken) -> Promise<String?> {
         return Promise { seal in
-            if decodedJWTToken.intent?.contains("_REDIRECTION") == true {
+            if let intent = decodedJWTToken.intent, intent.contains("_REDIRECTION") {
                 if let redirectUrlStr = decodedJWTToken.redirectUrl,
                    let redirectUrl = URL(string: redirectUrlStr),
                    let statusUrlStr = decodedJWTToken.statusUrl,

@@ -63,15 +63,15 @@ extension PrimerHeadlessKlarnaComponent: PrimerKlarnaProviderAuthorizationDelega
      */
     public func primerKlarnaWrapperAuthorized(approved: Bool, authToken: String?, finalizeRequired: Bool) {
         isFinalizationRequired = finalizeRequired
-        if approved == false {
-            if finalizeRequired == true {
+        if approved  {
+            if finalizeRequired {
                 let step = KlarnaStep.paymentSessionFinalizationRequired
                 stepDelegate?.didReceiveStep(step: step)
             } else {
                 createSessionError(.klarnaAuthorizationFailed)
             }
         }
-        if let authToken = authToken, approved == true {
+        if let authToken = authToken, approved {
             if PrimerInternal.shared.sdkIntegrationType == .headless {
                 finalizeSession(token: authToken, fromAuthorization: true)
             } else {
@@ -80,7 +80,7 @@ extension PrimerHeadlessKlarnaComponent: PrimerKlarnaProviderAuthorizationDelega
                 self.stepDelegate?.didReceiveStep(step: step)
             }
         }
-        if finalizeRequired == true {
+        if finalizeRequired {
             let step = KlarnaStep.paymentSessionFinalizationRequired
             stepDelegate?.didReceiveStep(step: step)
         }

@@ -25,10 +25,10 @@ extension PrimerHeadlessKlarnaComponent: PrimerKlarnaProviderFinalizationDelegat
      *  - `authToken` - An optional `String` containing the authorization token, which is returned only if `approved` is `true`.
      */
     public func primerKlarnaWrapperFinalized(approved: Bool, authToken: String?) {
-        if approved == false {
+        if approved  {
             createSessionError(.klarnaFinalizationFailed)
         }
-        if let authToken = authToken, approved == true {
+        if let authToken = authToken, approved {
             if PrimerInternal.shared.sdkIntegrationType == .headless {
                 finalizeSession(token: authToken, fromAuthorization: false)
             } else {

@@ -695,7 +695,7 @@ Make sure you call the decision handler otherwise the SDK will hang.
                         seal.reject(err)
                     }
 
-                } else if decodedJWTToken.intent?.contains("_REDIRECTION") == true {
+                } else if let intent = decodedJWTToken.intent, intent.contains("_REDIRECTION") {
                     if let redirectUrlStr = decodedJWTToken.redirectUrl,
                        let redirectUrl = URL(string: redirectUrlStr),
                        let statusUrlStr = decodedJWTToken.statusUrl,

@@ -597,7 +597,7 @@ Make sure you call the decision handler otherwise the SDK will hang."
                         seal.reject(err)
                     }
 
-                } else if decodedJWTToken.intent?.contains("_REDIRECTION") == true {
+                } else if let intent = decodedJWTToken.intent, intent.contains("_REDIRECTION") {
                     if let statusUrlStr = decodedJWTToken.statusUrl,
                        let statusUrl = URL(string: statusUrlStr),
                        decodedJWTToken.intent != nil {

@@ -596,7 +596,7 @@ extension PrimerHeadlessUniversalCheckout {
                         seal.reject(err)
                     }
 
-                } else if decodedJWTToken.intent?.contains("_REDIRECTION") == true {
+                } else if let intent = decodedJWTToken.intent, intent.contains("_REDIRECTION") {
                     if let statusUrlStr = decodedJWTToken.statusUrl,
                        let statusUrl = URL(string: statusUrlStr),
                        decodedJWTToken.intent != nil {

@@ -229,7 +229,7 @@ struct DecodedJWTToken: Codable {
         try? container.encode(expDate?.timeIntervalSince1970, forKey: .expiration)
         try? container.encode(expDate?.timeIntervalSince1970, forKey: .exp)
 
-        if qrCode?.isHttpOrHttpsURL == true {
+        if let qrCode = qrCode, qrCode.isHttpOrHttpsURL {
             try? container.encode(qrCode, forKey: .qrCodeUrl)
         } else {
             try? container.encode(qrCode, forKey: .qrCode)

@@ -29,7 +29,7 @@ internal struct OrderItem: Codable {
         let tmpTaxAmount = taxAmount ?? 0
         let tmpTotalOrderItemAmount = tmpAmount - tmpDiscountAmount + tmpTaxAmount
 
-        if AppState.current.currency?.isZeroDecimal == true {
+        if let currency = AppState.current.currency, currency.isZeroDecimal {
             applePayItemAmount = NSDecimalNumber(value: tmpTotalOrderItemAmount)
         } else {
             applePayItemAmount = NSDecimalNumber(value: tmpTotalOrderItemAmount).dividing(by: 100)

@@ -114,7 +114,7 @@ extension Response.Body {
 
             let supportedNetworks = ApplePayUtils.supportedPKPaymentNetworks()
             var canMakePayment: Bool
-            if PrimerSettings.current.paymentMethodOptions.applePayOptions?.checkProvidedNetworks == true {
+            if let options = PrimerSettings.current.paymentMethodOptions.applePayOptions, options.checkProvidedNetworks {
                 canMakePayment = PKPaymentAuthorizationController.canMakePayments(usingNetworks: supportedNetworks)
             } else {
                 canMakePayment = PKPaymentAuthorizationController.canMakePayments()

@@ -70,7 +70,7 @@ extension KeyedDecodingContainer {
         guard contains(key) else {
             return nil
         }
-        guard try decodeNil(forKey: key) == false else {
+        guard try decodeNil(forKey: key)  else {
             return nil
         }
         return try decode(type, forKey: key)
@@ -85,7 +85,7 @@ extension KeyedDecodingContainer {
         guard contains(key) else {
             return nil
         }
-        guard try decodeNil(forKey: key) == false else {
+        guard try decodeNil(forKey: key)  else {
             return nil
         }
         return try decode(type, forKey: key)
@@ -117,7 +117,7 @@ extension UnkeyedDecodingContainer {
 
     mutating func decode(_ type: Array<Any>.Type) throws -> [Any] {
         var array: [Any] = []
-        while isAtEnd == false {
+        while isAtEnd  {
             // See if the current value in the JSON array is `null` first and prevent infite recursion with nested arrays.
             if try decodeNil() {
                 continue

@@ -113,11 +113,11 @@ class ImageFileProcessor {
                 }
 
                 let coloredImageFile = paymentMethodImageFiles
-                    .filter({ $0.fileName.contains("dark") == false && $0.fileName.contains("light") == false }).first
+                    .filter({ $0.fileName.contains("dark")  && $0.fileName.contains("light")  }).first
                 let darkImageFile = paymentMethodImageFiles
-                    .filter({ $0.fileName.contains("dark") == true }).first
+                    .filter({ $0.fileName.contains("dark") }).first
                 let lightImageFile = paymentMethodImageFiles
-                    .filter({ $0.fileName.contains("light") == true }).first
+                    .filter({ $0.fileName.contains("light") }).first
 
                 let baseImage = PrimerTheme.BaseImage(
                     colored: coloredImageFile?.image,

@@ -23,7 +23,7 @@ class ClientSessionActionsModule: ClientSessionActionsProtocol {
                 return
             }
 
-            if (PrimerAPIConfigurationModule.apiConfiguration?.hasSurchargeEnabled ?? false) == false {
+            if (PrimerAPIConfigurationModule.apiConfiguration?.hasSurchargeEnabled ?? false)  {
                 seal.fulfill()
                 return
             }
@@ -65,7 +65,7 @@ class ClientSessionActionsModule: ClientSessionActionsProtocol {
                 return
             }
 
-            if (PrimerAPIConfigurationModule.apiConfiguration?.hasSurchargeEnabled ?? false) == false {
+            if (PrimerAPIConfigurationModule.apiConfiguration?.hasSurchargeEnabled ?? false)  {
                 seal.fulfill()
                 return
             }

@@ -68,7 +68,7 @@ internal class ImageFile: File {
     var bundledImage: UIImage? {
         let paymentMethodType = ImageFile.getPaymentMethodType(fromFileName: self.fileName) ?? self.fileName
 
-        if self.fileName.contains("dark") == true {
+        if self.fileName.contains("dark") {
             if let paymentMethodLogoFileName = ImageFile.getBundledImageFileName(forPaymentMethodType: paymentMethodType,
                                                                                  themeMode: .dark,
                                                                                  assetType: .logo),
@@ -81,7 +81,7 @@ internal class ImageFile: File {
                                           compatibleWith: nil) {
                 return image
             }
-        } else if self.fileName.contains("light") == true {
+        } else if self.fileName.contains("light") {
             if let paymentMethodLogoFileName = ImageFile.getBundledImageFileName(forPaymentMethodType: paymentMethodType,
                                                                                  themeMode: .light,
                                                                                  assetType: .logo),
@@ -94,7 +94,7 @@ internal class ImageFile: File {
                                           compatibleWith: nil) {
                 return image
             }
-        } else if self.fileName.contains("colored") == true {
+        } else if self.fileName.contains("colored") {
             if let paymentMethodLogoFileName = ImageFile.getBundledImageFileName(forPaymentMethodType: paymentMethodType,
                                                                                  themeMode: .colored,
                                                                                  assetType: .logo),

@@ -1002,7 +1002,7 @@ class UserInterfaceModule: NSObject, UserInterfaceModuleProtocol {
     }()
 
     var isSubmitButtonAnimating: Bool {
-        submitButton?.isAnimating == true
+        submitButton?.isAnimating ?? false
     }
 
     // MARK: - INITIALIZATION

@@ -179,7 +179,7 @@ internal class URLSessionStack: NetworkService, LogReporter {
                 }
                 #endif
 
-                if endpoint.shouldParseResponseBody == false, httpResponse?.statusCode == 200 {
+                if endpoint.shouldParseResponseBody , httpResponse?.statusCode == 200 {
                     guard let dummyRes: T = DummySuccess(success: true) as? T
                     else {
                         fatalError()