Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes build issue when combined with lower iOS target dependencies #5

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

NQuinn27
Copy link
Contributor

@NQuinn27 NQuinn27 commented Oct 20, 2023

This PR adds the flags in the Podspec which we see in Primer3DS, which allow us to mix the iOS 13.1 target of PrimerNolPaySDK with the original iOS 10 target of PrimerSDK

This PR also implements the automatic tagging workflow for trial.

This requires a companion PR in primer-sdk-ios - which will require this to be released to prepare

@NQuinn27 NQuinn27 requested a review from a team as a code owner October 20, 2023 10:56
Copy link
Contributor

@borisprimer borisprimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NQuinn27 NQuinn27 merged commit 8867125 into master Oct 20, 2023
2 checks passed
@NQuinn27 NQuinn27 deleted the nq/swift_version_podspec branch October 24, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants