Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean cobadged example #6

Merged
merged 3 commits into from
Jan 31, 2024
Merged

chore: clean cobadged example #6

merged 3 commits into from
Jan 31, 2024

Conversation

rabelloo
Copy link
Contributor

@rabelloo rabelloo commented Jan 29, 2024 •
edited
Loading

  • Introduces spinner for indicating when card networks are loading, instead of previous text
  • Cleans all "TODOs"

@rabelloo rabelloo self-assigned this Jan 29, 2024
@rabelloo rabelloo marked this pull request as ready for review January 30, 2024 09:50
@rabelloo rabelloo requested a review from aabdaab January 30, 2024 09:50
aabdaab
aabdaab approved these changes Jan 31, 2024
View reviewed changes
Copy link

@aabdaab aabdaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌 works as expected!

@rabelloo rabelloo merged commit 28e022a into main Jan 31, 2024
3 checks passed
@rabelloo rabelloo deleted the clean branch January 31, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabdaab aabdaab aabdaab approved these changes

Assignees

@rabelloo rabelloo

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabelloo @aabdaab