Add AR6 Scenario Database variables #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 99.35% 99.35%
=======================================
Files 26 27 +1
Lines 1395 1397 +2
=======================================
+ Hits 1386 1388 +2
Misses 9 9
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Same problem as with other |
|
Also not sure how to deal with top-level categories which do not exist as variables in the DB, e.g. 'Price' Only For variables like |
|
Cool stuff! Having Prices grouped if there are multiple prices makes sense, I think. That's of course a deviation from the original definition, but it is a strict extension and unlikely to lead to problems in future updates of the categorization. We have precedents for that, the Due to being at a conference, I won't be able to look into this further before Easter, I fear. Cheers, Mika |
|
No worries, enjoy the conference and your holidays! As for the top-level category I didn't really add a new category, but only extracted the top-level one, so there are no |
|
Also need to check whether these are hierarchical (doesn't really look like it): |
They are definitely not |
|
Looks good, if it is ready from your side, I could add the necessary documentation in README etc. and merge. |
|
I don't think I looked through the questions above. |
|
I think it is pretty clear that the categorization is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Please confirm that this pull request has done the following:
.rstfile in the directorychangelog_unreleasedadded – remember to start with a*to make it a bullet pointDescription
First attempt at importing the AR6 Scenario Database variables.