-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AR6 Scenario Database variables #61
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 99.35% 99.35%
=======================================
Files 26 27 +1
Lines 1395 1397 +2
=======================================
+ Hits 1386 1388 +2
Misses 9 9
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Same problem as with other
|
Also not sure how to deal with top-level categories which do not exist as variables in the DB, e.g. 'Price'
Only For variables like |
Cool stuff! Having Prices grouped if there are multiple prices makes sense, I think. That's of course a deviation from the original definition, but it is a strict extension and unlikely to lead to problems in future updates of the categorization. We have precedents for that, the Due to being at a conference, I won't be able to look into this further before Easter, I fear. Cheers, Mika |
No worries, enjoy the conference and your holidays! As for the top-level category I didn't really add a new category, but only extracted the top-level one, so there are no |
Also need to check whether these are hierarchical (doesn't really look like it):
|
They are definitely not |
Looks good, if it is ready from your side, I could add the necessary documentation in README etc. and merge. |
I don't think I looked through the questions above. |
I think it is pretty clear that the categorization is |
Pull request
Please confirm that this pull request has done the following:
.rst
file in the directorychangelog_unreleased
added – remember to start with a*
to make it a bullet pointDescription
First attempt at importing the AR6 Scenario Database variables.