method to read conversion from csv

[crdanielbusch]

Pull request

Please confirm that this pull request has done the following:

• Tests added
• Documentation added (where applicable)
• Changelog snippet in a .rst file in the directory changelog_unreleased added – remember to start with a * to make it a bullet point

Description

Adds a public method that takes a csv file and returns a Conversion object. The user will then be able to generate a Conversion object with something like conversion = climate_categories.Conversion.from_csv("test.csv").

[mikapfl]

Nice work. I've found a simplification, a bit too big to include it here in the review, so I made a pull request into your branch, see #165

[mikapfl]

Also, I noticed that pre-commit CI was not running any more due to the move to the primap-community org. I re-enabled it, so we should get authoritative linting again in the CI. 🙂

[crdanielbusch]

I used the global ruff executable for code formatting in Pycharm, not sure which version. Now that we have the pre commit running again it should be the same format.

What are the guidelines for docstrings in PRIMAP2. The from_csv method just has a single line docstring at the moment. Other methods have the numpy stlye docstring with paramaters and output. I'm not sure which to use when.

[mikapfl]

Hi,

if you want to document parameters or need more space, use numpy style. If you think parameters don't need documentation and a single line is enough, just use a single line.

Cheers,

Mika

[mikapfl]

I think you have to merge main into this branch to make the pre-commit CI work automatically.

[crdanielbusch]

I think you have to merge main into this branch to make the pre-commit CI work automatically.

Perfect, thanks! Then that's ready to merge

[mikapfl]

You should be able to merge yourself, right?

[crdanielbusch]

You should be able to merge yourself, right?

Yep. Just forgot the changelog