-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
method to read conversion from csv #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I've found a simplification, a bit too big to include it here in the review, so I made a pull request into your branch, see #165
Also, I noticed that pre-commit CI was not running any more due to the move to the primap-community org. I re-enabled it, so we should get authoritative linting again in the CI. 🙂 |
I used the global ruff executable for code formatting in Pycharm, not sure which version. Now that we have the pre commit running again it should be the same format. What are the guidelines for docstrings in PRIMAP2. The |
Hi, if you want to document parameters or need more space, use numpy style. If you think parameters don't need documentation and a single line is enough, just use a single line. Cheers, Mika |
I think you have to merge main into this branch to make the pre-commit CI work automatically. |
for more information, see https://pre-commit.ci
Perfect, thanks! Then that's ready to merge |
You should be able to merge yourself, right? |
…mate_categories into conversion-from-csv pre commit changes
for more information, see https://pre-commit.ci
Yep. Just forgot the changelog |
Pull request
Please confirm that this pull request has done the following:
.rst
file in the directorychangelog_unreleased
added – remember to start with a*
to make it a bullet pointDescription
Adds a public method that takes a csv file and returns a
Conversion
object. The user will then be able to generate aConversion
object with something likeconversion = climate_categories.Conversion.from_csv("test.csv")
.