Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: PCardSlider 컴포넌트 구현 #99

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

thsk3
Copy link
Collaborator

@thsk3 thsk3 commented Sep 30, 2024

📝 Summary

공연 포스터 슬라이드 컴포넌트를 구현했습니다.

✨ Changes

  • react-slick 라이브러리를 설치했습니다.
  • PCardSlider 컴포넌트를 추가했습니다.

🖼️ Screenshots

image image

✅ PR Checklist

  • 하나의 목적을 가진 PR입니다.
  • 코딩 컨벤션과 스타일 가이드를 준수합니다. 📌Conventions
  • 불필요한 코드 중복이 없습니다.
  • 컴포넌트의 책임이 단일합니다.
  • 리액트 훅을 올바르게 사용했습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

🔗 References

💬 Comments

@thsk3 thsk3 linked an issue Sep 30, 2024 that may be closed by this pull request
@thsk3 thsk3 force-pushed the 79-feature/pcardslider-component branch from 9273473 to 881b064 Compare October 1, 2024 02:44
src/components/PCardSlider/index.tsx Outdated Show resolved Hide resolved
src/components/PCardSlider/index.tsx Outdated Show resolved Hide resolved
src/components/PCardSlider/index.tsx Outdated Show resolved Hide resolved
src/components/PCardSlider/index.tsx Outdated Show resolved Hide resolved
src/components/PCardSlider/index.tsx Outdated Show resolved Hide resolved
- react-slick 라이브러리 설치
- 커서로 스와이프 할 수 있게 함
- rank 옵셔널 값으로 변경
- PCardSlider의 너비를 %로 줬을 때, PCard의 너비도 %로 적용되는 것 수정
- 주어진 width의 형식을 확인하고 형식에 따라 PCard의 너비를 다르게 적용해줌
@thsk3 thsk3 force-pushed the 79-feature/pcardslider-component branch from a88cf9e to a09c70d Compare October 2, 2024 06:38
thsk3 and others added 2 commits October 2, 2024 16:37
@shlee9999 shlee9999 force-pushed the 79-feature/pcardslider-component branch from d62ba71 to 57b62f1 Compare October 2, 2024 08:50
src/components/PCard/index.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎯[Feature] PCardSlider 컴포넌트 구현
2 participants