-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: PCardSlider 컴포넌트 구현 #99
Open
thsk3
wants to merge
6
commits into
main
Choose a base branch
from
79-feature/pcardslider-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+139
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsk3
force-pushed
the
79-feature/pcardslider-component
branch
from
October 1, 2024 02:44
9273473
to
881b064
Compare
shlee9999
requested changes
Oct 1, 2024
shlee9999
requested changes
Oct 2, 2024
- react-slick 라이브러리 설치
- 커서로 스와이프 할 수 있게 함
- rank 옵셔널 값으로 변경
- PCardSlider의 너비를 %로 줬을 때, PCard의 너비도 %로 적용되는 것 수정 - 주어진 width의 형식을 확인하고 형식에 따라 PCard의 너비를 다르게 적용해줌
thsk3
force-pushed
the
79-feature/pcardslider-component
branch
from
October 2, 2024 06:38
a88cf9e
to
a09c70d
Compare
- PList나 Boxof 중 아무거나 줘도 잘 나오게 바꿈
shlee9999
force-pushed
the
79-feature/pcardslider-component
branch
from
October 2, 2024 08:50
d62ba71
to
57b62f1
Compare
shlee9999
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
공연 포스터 슬라이드 컴포넌트를 구현했습니다.
✨ Changes
🖼️ Screenshots
✅ PR Checklist
🔗 References
💬 Comments