Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

108 bug/api type dismatch #109

Merged
merged 2 commits into from
Sep 30, 2024
Merged

108 bug/api type dismatch #109

merged 2 commits into from
Sep 30, 2024

Conversation

shlee9999
Copy link
Collaborator

๐Ÿ“ Summary

API Response ํƒ€์ž… ์•ˆ๋งž์•„ ์ฐธ์กฐ ๋ถˆ๊ฐ€๋Šฅํ–ˆ๋˜ ๋ฌธ์ œ ํ•ด๊ฒฐ

โœจ Changes

  • API Response๋ฅผ ํ…Œ์ŠคํŠธํ•ด๋ณด๋ฉฐ ํƒ€์ž…์„ ์ง์ ‘ ๋งž์ถฐ์คŒ
  • API Docs์— Example๋„ ์ถ”๊ฐ€ํ•จ

๐Ÿ–ผ๏ธ Screenshots

{DB1E547A-C11F-400E-8BF2-1139142E5B3E}

โœ… PR Checklist

  • ํ•˜๋‚˜์˜ ๋ชฉ์ ์„ ๊ฐ€์ง„ PR์ž…๋‹ˆ๋‹ค.
  • ์ฝ”๋”ฉ ์ปจ๋ฒค์…˜๊ณผ ์Šคํƒ€์ผ ๊ฐ€์ด๋“œ๋ฅผ ์ค€์ˆ˜ํ•ฉ๋‹ˆ๋‹ค. ๐Ÿ“ŒConventions
  • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ ์ค‘๋ณต์ด ์—†์Šต๋‹ˆ๋‹ค.
  • ์ปดํฌ๋„ŒํŠธ์˜ ์ฑ…์ž„์ด ๋‹จ์ผํ•ฉ๋‹ˆ๋‹ค.
  • ๋ฆฌ์•กํŠธ ํ›…์„ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์‚ฌ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋ฏผ๊ฐํ•œ ์ •๋ณด๋ฅผ ํฌํ•จํ•˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค.
  • ๋ถˆํ•„์š”ํ•œ ์ฝ˜์†” ๋กœ๊ทธ๋‚˜ ์ฃผ์„์„ ํฌํ•จํ•˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค.
  • ์ปดํฌ๋„ŒํŠธ key๊ฐ’์— ๊ณ ์œ ํ•œ ๊ฐ’์„ ํ• ๋‹นํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ”— References

๐Ÿ’ฌ Comments

์—†์Œ

@shlee9999 shlee9999 linked an issue Sep 30, 2024 that may be closed by this pull request
๐Ÿชฒ[BUG] API Type ๋ถˆ์ผ์น˜ #108
Closed
@shlee9999 shlee9999 merged commit 00cb2af into main Sep 30, 2024
1 check passed
@shlee9999 shlee9999 deleted the 108-bug/api-type-dismatch branch October 2, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluedog129 bluedog129 bluedog129 approved these changes

@se0kcess se0kcess se0kcess approved these changes

@thsk3 thsk3 thsk3 approved these changes

Assignees

@shlee9999 shlee9999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๐Ÿชฒ[BUG] API Type ๋ถˆ์ผ์น˜
4 participants
@shlee9999 @bluedog129 @se0kcess @thsk3