Refactor: PCard 컴포넌트 props 수정

- rank 옵셔널 값으로 변경
prgrms-fe-devcourse · Oct 2, 2024 · a5772dc · a5772dc
1 parent 460cb90
commit a5772dc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/src/components/PCard/index.tsx b/src/components/PCard/index.tsx
@@ -6,13 +6,13 @@ import { CommonResponseType } from '@/types/apis';
 interface PCardProps {
   pInfo: Pick<CommonResponseType, 'mt20id' | 'poster' | 'prfnm' | 'fcltynm' | 'prfpdfrom' | 'prfpdto'>;
   width?: string;
-  rank?: number | null;
+  rank?: number;
 }
 
-export const PCard = ({ pInfo, width = '225px', rank = null }: PCardProps) => {
+export const PCard = ({ pInfo, width = '225px', rank }: PCardProps) => {
   return (
     <S.PCard width={width}>
-      <Poster src={pInfo.poster} rank={rank}></Poster>
+      <Poster src={pInfo.poster} rank={rank} />
       <S.PCardText>
         <H16>{pInfo.prfnm}</H16>
         <P15>{pInfo.fcltynm}</P15>

diff --git a/src/components/PCardSlider/index.tsx b/src/components/PCardSlider/index.tsx
@@ -7,14 +7,14 @@ import { PCard } from '@/components/PCard';
 
 interface PCardSliderProps {
   /**
-   * Omit<PListResponseType, 'genrenm' | 'prfstate' | 'openrun' | 'area'> 과 동일
+   * Omit<PListResponseType, 'genrenm' | 'prfstate' | 'openrun' | 'area'>[] 과 동일
    */
   pList: Pick<CommonResponseType, 'mt20id' | 'poster' | 'prfnm' | 'fcltynm' | 'prfpdfrom' | 'prfpdto'>[];
   width?: string;
   isRanked?: boolean;
 }
 
-export const PCardSlider = ({ pList, width = '600px', isRanked = false }: PCardSliderProps) => {
+export const PCardSlider = ({ pList, width = '100%', isRanked }: PCardSliderProps) => {
   const settings = {
     infinite: true,
     speed: 500,
@@ -27,12 +27,7 @@ export const PCardSlider = ({ pList, width = '600px', isRanked = false }: PCardS
       <Slider {...settings}>
         {pList.map((perform, index) => {
           return (
-            <PCard
-              key={index}
-              pInfo={perform}
-              width={`calc(${width} / 5.2)`}
-              {...(isRanked && { rank: index + 1 })}
-            ></PCard>
+            <PCard key={index} pInfo={perform} width={`calc(${width} / 5.2)`} {...(isRanked && { rank: index + 1 })} />
           );
         })}
       </Slider>