-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#338] Refactor: main page 탠스택 쿼리 적용 #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunSukHyun
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엄청난 작업령이군요 수고하셨습니다.
HoberMin
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수학님 고생하셨습니다 리뷰 확인하시고 태그해서 한번 불러주세요 !!
리뷰폭탄이긴한데 재대로 된 리뷰가 포함되어있는지 잘 모르겠네요 👍
…ts hooks 에서 keepPreviousData 삭제
HoberMin
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 Issue Number
🤷♂️ Description
메인페이지서 get 요청되는 것을 tanstack query 로 수정합니다.
search posts api 는 모든 posts 를 불러올수밖에 없어 useQuery 로 작성합니다.
메인 페이지의 PostList 컴포넌트의 책임이 너무 큰것같아, 분리 합니다.
@rollup/rollup-win32-x64-msvc missing 버그로 인해 해당 의존성 추가합니다.
✅Todo
📷 Screenshots
이렇게 분리했습니다
👻 Good Function
📋 Check List
📒 Remarks
notion 에 useInfiniteQuery 관련글 작성하여 공유하겠습니다,