[Mission5/이범진] Project_Notion_VanillaJs 과제 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euan-lee
changed the title
from1to2
reviewed
Jul 10, 2023
| if(timer !== null){ | ||
| clearTimeout(timer) | ||
| } | ||
|
|
There was a problem hiding this comment.
디바운싱이 적용된 점이 인상깊네요! 저는 나중에 쓰로틀링 직접 적용해보고 싶어요 👍
| try{ | ||
| const res = await fetch(`${API_END_POINT}${url}`,{ | ||
| ...options, | ||
| headers:{ |
There was a problem hiding this comment.
request로 반복되는 API 요청을 일반화 시키는 부분이 인상적이네요! 👍
|
|
||
| export const removeItem = (key) => { | ||
| storage.removeItem(key) | ||
| } |
There was a problem hiding this comment.
localStorage 관련된 모든 함수를 한 곳에 모아두어서 보기 편한거 같아요 😄
eeseung
reviewed
Jul 12, 2023
pers0n4
reviewed
Jul 16, 2023
| const $target = document.querySelector('#app') | ||
|
|
||
| new App({$target}) | ||
| console.log() |
Comment on lines
+3
to
+10
| export const request = async (url,options ={})=>{ | ||
| try{ | ||
| const res = await fetch(`${API_END_POINT}${url}`,{ | ||
| ...options, | ||
| headers:{ | ||
| 'Content-Type':'application/json', | ||
| } | ||
| }) |
|
|
||
| const fetchPosts = async () => { | ||
| const posts = await request('posts') | ||
| console.log("posts",posts) |
There was a problem hiding this comment.
운영 환경에서 로그 데이터가 사용자에게 노출되는 상황이 바람직한 상황은 아닙니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현다 못했습니다.. ㅠㅠ
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ 피드백 반영사항
✅ PR 포인트 & 궁금한 점