Feat : CommentRepository 구현 #56
Open
+347
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbw9964
approved these changes
Oct 2, 2024
| "test", | ||
| "testTitle", | ||
| "posterUrl", | ||
| Genre.ACTION, |
There was a problem hiding this comment.
저희 KMDB 에서 영화 장르가 "액션, 모험"" 처럼 여러개 나와서
Genre 대신 String 으로 바꿔야 되지 않나요?
There was a problem hiding this comment.
맞네요.. MovieEntity 수정전에 작업해서 그 부분을 확인 못했네요
이 부분은 수정하고 push 하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
CommentRepository에 해당하는 코드를 구현하였습니다.
👩💻 요구 사항과 구현 내용
기존에 있던 CommentRepository 인터페이스에 존재하는 기능에 맞춰 구현하였습니다.
✅ 피드백 반영사항
✅ PR 포인트 & 궁금한 점