[#31] [FRATURE] 응급실 길찾기 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0o0bn
approved these changes
Oct 1, 2024
|
|
||
| @RequiredArgsConstructor | ||
| @Component | ||
| public class EmergencyRoomDirections { |
There was a problem hiding this comment.
별건 아닌데 Directions 라는 이름이 엔티티에 가깝다는 느낌이 들어서
혹시 Router 이런 이름은 어떠신가용
| @@ -7,4 +7,6 @@ public interface EmergencyRoomClient { | |||
| List<RealTimeEmergencyRoomInfo> getRealTimeInfo(Region region); | |||
|
|
|||
| List<EmergencyRoomInfo> getEmergencyRoomInfoData(); | |||
|
|
|||
| EmergencyRoomDirectionsInfo directionsEmergencyRoom(String start, String end); | |||
There was a problem hiding this comment.
getRouteToEmergencyRoom 이런거 어떨까요 아니면 find?
| @@ -41,4 +41,8 @@ public double distanceTo(Coordinate targetCoordinate) { | |||
|
|
|||
| return Math.round(EARTH_RADIUS_KM * c * 100) / 100.0; | |||
| } | |||
|
|
|||
| public String convertorLatitudeAndLongitude() { | |||
There was a problem hiding this comment.
메서드명은 동사로 명명하는 게 좋을 거 같아서 convert가 나을 것 같습니당
아니면 getGps ..? 음 애매하네요 ㅋㅋㅋ
|
감사합니다 ㅎㅎ |
|
https://api.ncloud-docs.com/docs/ai-naver-mapsdirections-driving#%EC%9D%91%EB%8B%B5 |
JiwonKKang
force-pushed
the
feature/emergency-directions
branch
from
6bb3394
to
695d261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현 기능 명세
✅ PR Point
😭 어려웠던 점