[FEAT] 대기열 구현 #32
Open
[FEAT] 대기열 구현 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 대기열 진입 API - 웨이팅 수 반환 요청 API - 웨이팅 큐 탈출 API
- 기존 Manager를 두었던 체계에서 상위에 facade서비스를 두는 방식으로 변경하였습니다.
AnTaeho
approved these changes
Oct 2, 2024
Comment on lines
+23
to
+30
| private final SecretKey secretKey; | ||
| private final Integer expirationTime; | ||
| private static final String SIGNATURE_ALGORITHM = Jwts.SIG.HS256.key().build().getAlgorithm(); | ||
|
|
||
| JwtUtil(@Value("${jwt.secret}") String secretKey, @Value("${jwt.expiration_time}") Integer expirationTime) { | ||
| this.secretKey = new SecretKeySpec(secretKey.getBytes(StandardCharsets.UTF_8), SIGNATURE_ALGORITHM); | ||
| this.expirationTime = expirationTime; | ||
| } |
There was a problem hiding this comment.
사실 저는 무슨 auth0-jwt 였나 하는 라이브러리만 써보고
jjwt 라이브러리를 처음 써봐서 엄청 엉성한데 한 수 배워갑니다.
Comment on lines
+11
to
+14
| @Service | ||
| @Transactional | ||
| @RequiredArgsConstructor | ||
| public class QueueServiceImpl implements QueueService { |
There was a problem hiding this comment.
P3
여기에 @transactional은 필요 없지 않을까요??
There was a problem hiding this comment.
그로네용..습관이 무섭습니다....
Comment on lines
+15
to
+20
| @Scheduled(fixedRate = 30 * 1000) //30초마다 | ||
| public void updateWaitingToProcessing() { | ||
| queueCommandService.removeExpiredToken(); | ||
| queueCommandService.updateWaitingToProcessing(); | ||
| log.info("processing queue 가 update 되었습니다."); | ||
| } |
There was a problem hiding this comment.
저는 만료된 토큰 제거는 생각하지도 않았네요 ㅜㅠㅠㅠ
| import static com.example.book_your_seat.queue.QueueConst.*; | ||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| public class QueueServiceTest extends IntegralTestSupport { |
There was a problem hiding this comment.
혹시 테스트의 for들이 전부 1000번 부터 시작하는데 이유가 있을까요?
There was a problem hiding this comment.
그냥 혹시라도 아까처럼 id문제가 생길까봐 안전하게 했습니다 ㅎㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
대기열 서비스를 구현했습니다.
👩💻 요구 사항과 구현 내용
1. 큐 진입 API (토큰발급)
2. 큐 정보 반환 요청 API (상태랑 대기 수)
3. 대기 큐 탈출 API
4. 예매 성공 시 진행 큐 탈출 요청 함수 작성
5. 30초마다 대기큐 -> 처리큐 Update 스케줄러 작성
✅ PR 포인트 & 궁금한 점
빼먹은게 있으면 편하게 말씀 주쎄요~!
그리고 yml 파일을 따로 .gitignore 처리 해두지 않아서 jwt관련 정보들이 공개되어있는데, 임시니까 일단 공개해둡니다!!