Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnTaeho
reviewed
Oct 2, 2024
|
|
||
|
|
||
| @GetMapping | ||
| public Slice<UserCouponResponse> getUserCoupons(@Valid UserCouponRequest userCouponRequest, HttpServletRequest request, Pageable pageable) { |
There was a problem hiding this comment.
P2
@RequestBody 필요할 것 같습니다!
Comment on lines
+6
to
+12
| public record UserCouponRequest( | ||
| @NotNull | ||
| Boolean used | ||
| ) { | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
P4
만약에 Boolean에 null이 들어오면 사용/미사용 모두 보여주는 것은 어떤가요?
| } | ||
|
|
||
| @Override | ||
| public Slice<UserCouponResponse> selectUserCoupons(UserCouponRequest userCouponRequest,Long memberId, Pageable pageable) { |
There was a problem hiding this comment.
P4
저희 엔티티 명이 user니까 memberId 말고 userId는 어떨까요?
tnals2384
reviewed
Oct 2, 2024
Comment on lines
+28
to
+29
| public Slice<UserCouponResponse> getUserCoupons(@Valid UserCouponRequest userCouponRequest, HttpServletRequest request, Pageable pageable) { | ||
| Long userId = getUserId(request); |
There was a problem hiding this comment.
궁금해서 여쭤봅니당!! 혹시 UserCouponRequest에서 used 하나만 받아오는데 파라미터나 pathvariable이 아닌 dto로 받아오는 특별한 이유가 있을까요?!?
| } | ||
|
|
||
| @Override | ||
| public Slice<UserCouponResponse> selectUserCoupons(UserCouponRequest userCouponRequest,Long memberId, Pageable pageable) { |
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| @SpringBootTest |
There was a problem hiding this comment.
P4
여기도 관현님이 말씀하신것처럼 @SpringBootTest를 한번 더쓰는 것보다 IntegralTestSupport를 상속받는 게 어떨까욥??
| //then | ||
|
|
||
| PageRequest pageRequest2 = PageRequest.of(1, 20); //10장 남음 | ||
| Slice<UserCouponResponse> userCoupons2 = userCouponService.getUserCoupons(userCouponRequest, 1L, pageRequest2); |
There was a problem hiding this comment.
P2
여기도 1L 대신 user.getId()로 사용하는게 더 안전할 것 같아요!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ 피드백 반영사항
✅ PR 포인트 & 궁금한 점